Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High DPI display support #822

Open
scribblemaniac opened this issue Dec 2, 2017 · 7 comments
Open

High DPI display support #822

scribblemaniac opened this issue Dec 2, 2017 · 7 comments
Labels
DPI Enhancement UI Related to the visual appearance of the program

Comments

@scribblemaniac
Copy link
Member

Screens with higher pixel densities and resolutions are becoming more common, especially among artists. This is what Pencil2D currently looks like on a 4k display:
screenshot from 2017-12-01 23-16-27
There are issues all over the place, from clipped text in the timeline to a minuscule toolbox to a rather small color palette (that is with the large option!) and color wheel. If I'm not mistaken there were multiple issues related to this in the forums, but to my surprise I could not find an issue on it on Github. So this issue will be for tracking all of the changes that need to be done to make Pencil2D work just as well on high resolution displays, if not better.

See here for some details on Qt and High DPI support: https://doc.qt.io/qt-5/highdpi.html

@scribblemaniac scribblemaniac added Enhancement UX Related to the way users interact with the program labels Dec 2, 2017
@Jose-Moreno
Copy link
Member

Here's reference to #597 which has a record of several related cases that span from this issue alone.

@scribblemaniac
Copy link
Member Author

scribblemaniac commented Dec 2, 2017

@Jose-Moreno Thank you, how did I not find that! I even commented on it 🤣 This will still be useful for specifically tracking High DPI support integration I think.

@chchwy chchwy added this to the 6.1 milestone Feb 3, 2018
@chchwy
Copy link
Member

chchwy commented Mar 5, 2018

According to http://doc.qt.io/qt-5/highdpi.html, we can set Qt::AA_EnableHighDpiScaling
The font will be a little bit blurry after setting the attribute on a high dpi display.
So it's not an ultimate solution, but it's a quick fix for tiny UI.

@chchwy chchwy modified the milestones: 6.1, 6.2 Mar 15, 2018
@chchwy
Copy link
Member

chchwy commented Mar 15, 2018

Introducing a quick fix in f6c80da. A more proper solution will be done in 0.6.2.

@chchwy chchwy modified the milestones: 0.6.2, 0.6.3 Aug 6, 2018
@Jose-Moreno Jose-Moreno added the DPI label Aug 9, 2018
@scribblemaniac scribblemaniac removed this from the 0.6.4 milestone May 2, 2019
@J5lx J5lx added UI Related to the visual appearance of the program and removed UX Related to the way users interact with the program labels Aug 7, 2020
@MrStevns
Copy link
Member

MrStevns commented Sep 29, 2023

Scribble, what's the status of this as of our latest nightly build?

I am using a retina display although not 4k and it looks fine but i can't speak much for the small icons since my resolution is only about 2k

@scribblemaniac
Copy link
Member Author

I just tested a build from master and the nightly build AppImage on my 4k laptop (Ubuntu 22.04). The situation is greatly improved since my initial post. Almost everything looks good now. There are still some icons non-svg icons that are blurry, but that will probably be fixed by #1361. The only significant issue I saw in my limited testing is that the tool cursor icons are too small. If that is fixed, I would not be opposed to resolving this issue, although it would be best if we could have someone test high dpi support on macOS and Windows first.

@MrStevns
Copy link
Member

MrStevns commented Oct 3, 2023

Excellent, so we're almost there. Thanks for looking into it.

We will get new tool cursor icons in the UI redesign PR too. When you have time, would you mind trying out that PR and see if it's been improved.
Here's the latest snapshot: https://get.pencil2d.org/@Fatih20/6389400624/pencil2d-linux-42-2023-10-03

When i run the application with the highest resolution I can, the icons seem to scale properly for me, at least the same amount the system icons does, so I'm not sure small cursor icons is a problem on Mac OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPI Enhancement UI Related to the visual appearance of the program
Projects
Status: To Do
Status: Medium Priority
Development

No branches or pull requests

5 participants