Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to composable executor for Ethereum #11838

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Oct 17, 2024

Towards #11274

  • Removes module reth_evm_ethereum::execute and renames reth_evm_ethereum::strategy -> reth_evm_ethereum::execute
  • Adds helper type EthExecutorProvider that offers the same API as the old provider type to minimize the impact of the change.
  • Changes to use composable executor types BasicBlockExecutorProvider and EthExecutionStrategyFactory where needed.

Successful executions of hive https://github.com/paradigmxyz/reth/actions/runs/11388193195 and kurtosis https://github.com/paradigmxyz/reth/actions/runs/11388196289

@fgimenez fgimenez added C-enhancement New feature or request A-execution Related to the Execution and EVM labels Oct 17, 2024
@fgimenez fgimenez force-pushed the fgimenez/switch-to-composable-executors-eth branch 3 times, most recently from 9bd8a71 to 2f4073b Compare October 17, 2024 15:08
@fgimenez fgimenez marked this pull request as ready for review October 17, 2024 16:05
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I like the new abstraction / implementation a lot

@Rjected
Copy link
Member

Rjected commented Oct 18, 2024

Let's wait until #11865 is merged to merge this, marking this as blocked for now

@Rjected Rjected added the S-blocked This cannot more forward until something else changes label Oct 18, 2024
@onbjerg onbjerg removed the S-blocked This cannot more forward until something else changes label Oct 19, 2024
@onbjerg
Copy link
Member

onbjerg commented Oct 19, 2024

This is no longer blocked @Rjected @fgimenez :)

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, pending smol conflicts

@fgimenez fgimenez force-pushed the fgimenez/switch-to-composable-executors-eth branch from cf15ec5 to 7a2a1ee Compare October 19, 2024 17:39
@fgimenez fgimenez force-pushed the fgimenez/switch-to-composable-executors-eth branch from 7a2a1ee to c51d22b Compare October 19, 2024 17:44
@fgimenez fgimenez added this pull request to the merge queue Oct 19, 2024
Merged via the queue into main with commit cd828c0 Oct 19, 2024
40 checks passed
@fgimenez fgimenez deleted the fgimenez/switch-to-composable-executors-eth branch October 19, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants