Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to composable executor for Optimism #11846

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: switch to composable executor for Optimism #11846

wants to merge 3 commits into from

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Oct 17, 2024 •
edited
Loading

Closes #11274
Requires #11838

  • Removes module reth_optimism_evm::execute and renames reth_optimism_evm::strategy -> reth_optimism_evm::execute
  • Adds helper type OpExecutorProvider that offers the same API as the old provider type to minimize the impact of the change.
  • Changes to use composable executor types BasicBlockExecutorProvider and OpExecutionStrategyFactory where needed.

Not sure if relevant in this case with the coverage we have at this point, but successful execution kurtosis https://github.com/paradigmxyz/reth/actions/runs/11389978820, i assume hive is not useful at all for op?

@github-actions github-actions bot added A-execution Related to the Execution and EVM C-enhancement New feature or request labels Oct 17, 2024
mattsse
mattsse approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah,
lgtm

@fgimenez fgimenez force-pushed the fgimenez/switch-to-composable-executors-eth branch 2 times, most recently from 7a2a1ee to c51d22b Compare October 19, 2024 17:44
Base automatically changed from fgimenez/switch-to-composable-executors-eth to main October 19, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg will be requested when the pull request is marked ready for review onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk will be requested when the pull request is marked ready for review rkrasiuk is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin will be requested when the pull request is marked ready for review shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected will be requested when the pull request is marked ready for review Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane will be requested when the pull request is marked ready for review emhane is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst will be requested when the pull request is marked ready for review gakonst is a code owner

Assignees
No one assigned
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgimenez @mattsse