feat(provider): add BlockchainProvider3 with only one view
#11706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-enhancement
joshieDo
force-pushed
the
joshie/bp3
branch
3 times, most recently
from
e4520b9
to
2539f1d
Compare
tcoratger
reviewed
Oct 14, 2024
joshieDo
force-pushed
the
joshie/bp3
branch
2 times, most recently
from
9e4b59e
to
6482f4a
Compare
joshieDo
commented
Oct 14, 2024
Comment on lines
2167
to
1931
| provider.canonical_in_memory_state.update_chain(chain); | ||
| let provider = provider_factory.provider3()?; | ||
|
|
||
| // Now the block should be found in memory | ||
| assert_eq!( | ||
| provider.find_block_by_hash(first_in_mem_block.hash(), BlockSource::Any)?, | ||
| Some(first_in_mem_block.clone().into()) | ||
| ); |
There was a problem hiding this comment.
notice that we need to instantiate a provider again to get the new in-memory view, otherwise this fails
joshieDo
force-pushed
the
joshie/bpf
branch
3 times, most recently
from
44c05b9
to
3dcc92b
Compare
joshieDo
force-pushed
the
joshie/bp3
branch
6 times, most recently
from
654d5d6
to
7f77e27
Compare
joshieDo
force-pushed
the
joshie/bpf
branch
2 times, most recently
from
646d376
to
a7c7d9a
Compare
joshieDo
force-pushed
the
joshie/bp3
branch
3 times, most recently
from
ad1c031
to
a15f656
Compare
joshieDo
force-pushed
the
joshie/bpf
branch
2 times, most recently
from
35c24da
to
8f73bba
Compare
joshieDo
force-pushed
the
joshie/bp3
branch
5 times, most recently
from
63d7d06
to
a1dad36
Compare
joshieDo
force-pushed
the
joshie/bp3
branch
4 times, most recently
from
83b942d
to
3d619e9
Compare
joshieDo
commented
Oct 17, 2024
| storage_provider: <ProviderFactory<N> as DatabaseProviderFactory>::Provider, | ||
| /// Storage provider factory. Necessary for `StateProviderFactory` since it takes ownership of | ||
| /// a read tx. | ||
| storage_provider_factory: ProviderFactory<N>, |
There was a problem hiding this comment.
factory goes away in #11778
joshieDo
requested review from
rakita,
shekhirin,
fgimenez and
rkrasiuk
as code owners
mattsse
reviewed
Oct 17, 2024
mattsse
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #11705
BP3and replaceBP2BP3holds aDatabaseProviderwith aDbTxand a headBlockState.CanonChainTracker,CanonStateSubscriptionsandForkChoiceSubscriptionsfromBP3. Should be called fromBPF