-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers): add AtomicBlockchainProvider
#11705
Open
joshieDo
wants to merge
7
commits into
main
Choose a base branch
from
joshie/bpf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,857
−1,216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-enhancement
New feature or request
A-db
Related to the database
A-blockchain-tree
Related to sidechains, reorgs and pending blocks
labels
Oct 14, 2024
joshieDo
commented
Oct 15, 2024
} | ||
|
||
#[cfg(test)] | ||
mod tests { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy pasted the tests and have them using the factory instead
joshieDo
force-pushed
the
joshie/bpf
branch
3 times, most recently
from
October 15, 2024 13:05
44c05b9
to
3dcc92b
Compare
joshieDo
requested review from
rakita,
shekhirin,
Rjected,
fgimenez,
emhane,
onbjerg and
rkrasiuk
as code owners
October 15, 2024 13:33
joshieDo
force-pushed
the
joshie/bpf
branch
8 times, most recently
from
October 17, 2024 01:55
1a84b0a
to
7579763
Compare
joshieDo
changed the title
feat(providers): add
feat(providers): add Oct 18, 2024
BlockchainProviderFactory
AtomicBlockchainProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-blockchain-tree
Related to sidechains, reorgs and pending blocks
A-db
Related to the database
C-enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtomicBlockchainProvider
, which ensures a single view on memory + db in most casesBlockchainProvider2
trait impls all create and useAtomicBlockchainProvider
https://github.com/paradigmxyz/reth/actions/runs/11404477525
closes #11497
rest of stack: #11706 #11778 #11841