Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: reserve of transient #42

Merged
merged 14 commits into from
May 17, 2024
Merged

Conversation

chefburger
Copy link
Collaborator

Completed test cases for #33

ChefMist
ChefMist previously approved these changes May 15, 2024
Copy link
Collaborator

@ChefMist ChefMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe in future PR we can improve a bit on this as we have a lot of .sync() scattered around in our tests which is not very neat.. maybe a library to help currency take/settlement

@ChefSnoopy
Copy link
Collaborator

Screenshot 2024-05-16 at 10 41 03

Need to update the snapshots file ?

@chefburger
Copy link
Collaborator Author

gas snapshots back

Updated. This is weird, it has happened several times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants