chore: Update with latest v4-core changes #32
Conversation
ChefMist
changed the title
ChefMist
requested review from
ChefSnoopy,
chefburger,
ChefCupcake and
chef-omelette
and removed request for
ChefSnoopy
| @@ -165,13 +166,13 @@ abstract contract CLSwapRouterBase is SwapRouterBase, ICLSwapRouterBase { | |||
| ); | |||
|
|
|||
| if (zeroForOne) { | |||
| reciprocalAmount = amountSpecified > 0 ? delta.amount1() : delta.amount0(); | |||
There was a problem hiding this comment.
might need some 👀 on this reciprocalAmount
chefburger
force-pushed
the
chore/update-v4-core
branch
from
adf7baa
to
60aeb60
Compare
src/pool-cl/CLSwapRouterBase.sol
Outdated
| reciprocalAmount = amountSpecified > 0 ? delta.amount1() : delta.amount0(); | ||
| if (settle) _payAndSettle(poolKey.currency0, payer, delta.amount0()); | ||
| if (take) vault.take(poolKey.currency1, recipient, uint128(-delta.amount1())); | ||
| reciprocalAmount = amountSpecified < 0 ? -delta.amount1() : -delta.amount0(); |
There was a problem hiding this comment.
is it better to not have minus here and flip sign for line 28, 62, 92, 123 ?
Reason: the return value reciprocalAmount is the delta of unspecified token according to the context, hence its sign should be aligned with BalanceDelta as well.
There was a problem hiding this comment.
i created a PR to further update -- pancakeswap/pancake-v4-periphery#34 can you see if this PR make sense? will merge to this branch if it make sense
|
pancakeswap/pancake-v4-periphery@60aeb60 changes is fine |
|
@chef-omelette @ChefSnoopy @ChefCupcake feel free to continue leaving comment, will address them. context: theres still more PR to come to further optimise our codebase due to the changes in v4-core |
Context
In the latest v4-core, a few changes has been made that impacts v4-periphery
flip BalanceDeltaandflip amountIneg. exactInput is when amountSpecified is negative: refactor: flip the sign for balanceDelta pancake-v4-core#49migrate over to transient storage for vault reserve Refactor: reserve of transient pancake-v4-core#42
adding
salt()concept to position: [PART-1] enable hooks to return deltas to influence pool behavior pancake-v4-core#44swapreturns 2 balanceDelta now: [PART-1] enable hooks to return deltas to influence pool behavior pancake-v4-core#44modifyLiquidityto also return 2 balanceDeltaChanges
Example of optimization required down the road
bytes32(0)