Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRDP-258] Added new Receipt status TO_REVIEW #91

Merged
merged 7 commits into from
Nov 30, 2023
Merged

[PRDP-258] Added new Receipt status TO_REVIEW #91

merged 7 commits into from
Nov 30, 2023

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Nov 30, 2023 •
edited
Loading

List of Changes

  • Added new receipt status TO_REVIEW
  • Updated ManageReceiptPoisonQueue function logic to update the receipt relative to the given bizEvent
  • Refactored getReceipt method from GenerateReceiptPdf function to a specific service class (ReceiptCosmosService)
  • Updated unit tests
  • Updated integration tests

Motivation and Context

Issue PRDP-258

How Has This Been Tested?

Unit & integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant added the patch label Nov 30, 2023
@svariant svariant self-assigned this Nov 30, 2023
@github-actions GitHub Actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

pasqualespica
pasqualespica approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pasqualespica pasqualespica merged commit 5622a29 into main Nov 30, 2023
9 of 12 checks passed
@svariant svariant mentioned this pull request Dec 1, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@svariant svariant

Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svariant @pasqualespica