Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRDP-261] Updated RetryReviewedPoisonMessages function #97

Merged
merged 12 commits into from
Dec 4, 2023
Merged

[PRDP-261] Updated RetryReviewedPoisonMessages function #97

merged 12 commits into from
Dec 4, 2023

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Dec 1, 2023

List of Changes

  • Implemented method to save receipt to cosmosDB
  • Updated RetryReviewedPoisonMessages logic to search receipt relative to poison bizEvent and update its status from TO_REVIEW to INSERT
  • Updated unit tests
  • Improved integration tests with more control on receipt status

Motivation and Context

Issue PRDP-261

Relates to PR-91

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant added enhancement New feature or request minor labels Dec 1, 2023
@svariant svariant marked this pull request as draft December 1, 2023 15:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.6% 80.6% Coverage
0.0% 0.0% Duplication

@svariant svariant marked this pull request as ready for review December 1, 2023 16:12
pasqualespica
pasqualespica approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasqualespica pasqualespica merged commit 2df85a2 into main Dec 4, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@svariant svariant

Labels
enhancement New feature or request minor size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svariant @pasqualespica