Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SIW-1043] Add CBOR decoding assertion function on iOS side #10

Merged
merged 6 commits into from
May 29, 2024

Conversation

hevelius
Copy link
Contributor

@hevelius hevelius commented May 9, 2024

Short description

This PR adds SwiftCBOR package to easily decoding CBOR assertion on iOS. So this PR introduces a new native function decodeAssertion. The output should be send to the backend.

Using CBOR on native side remove from the backend written in ts the computational cost of managed CBOR encoded data.

List of Changes

  • Add SwiftCBOR
  • Updated exmaple app
  • Update backend

How Has This Been Tested?

  • Set value in .env file under example app and backend
  • Start metro with cd example && yarn start
  • Start backend with cd backend && yarn start
  • Using a supported iOS device open Xcode and start the example app
  • Try sequentially all the CTA
  • Last CTA Verify Assertion should return a value like this {result: {signCount: 1}}

@LazyAfternoons LazyAfternoons changed the title [SIW-1043] Add CBOR decoding assertion function on iOS side feat: [SIW-1043] Add CBOR decoding assertion function on iOS side May 16, 2024
@LazyAfternoons LazyAfternoons self-requested a review May 29, 2024 11:09
Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hevelius hevelius merged commit 9960c97 into main May 29, 2024
9 checks passed
@hevelius hevelius deleted the SIW-1043-decode-ios-attestation branch May 29, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants