[#IOPLT-325] Add Flatten Mapping and refactor enrichment #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPLT-325 |
CrisTofani
reviewed
Jan 22, 2024
| import { pipe } from "fp-ts/lib/function"; | ||
| import { toJsonObject } from "../utils/data"; | ||
|
|
||
| export const flattenField = <T>(input: T, fieldToFlat: keyof T): T => |
There was a problem hiding this comment.
Suggested change
| export const flattenField = <T>(input: T, fieldToFlat: keyof T): T => | |
| export const flattenField = <T extends Record<string, unknown>>(input: T, fieldToFlat: keyof T): T => |
could be more explicit?
There was a problem hiding this comment.
I've used the same definition of other mappings :)
Maybe we can change generic type definition for all others formatters
drmarro
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
flattenFieldmappingblobenrichmenttableenrichmentMotivation and Context
This is required to allow denormalization in specific use cases when data stream is composed by sub-objects that can be flattened. If flatten occurs field names are renamed if original name overlaps with other existing properties
How Has This Been Tested?
unit tests
Screenshots (if appropriate):
Types of changes
Checklist: