-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #19 from pagopa/IOPLT-325_add_flatten_mapping
[#IOPLT-325] Add Flatten Mapping and refactor enrichment
- Loading branch information
Showing
6 changed files
with
128 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
import { withoutUndefinedValues } from "@pagopa/ts-commons/lib/types"; | ||
import { flattenField } from "../flatten"; | ||
|
||
const aNormalizedField = { | ||
bar: 1, | ||
baz: false | ||
}; | ||
|
||
const aNormalizedFieldWithAlreadyExistingProperty = { | ||
...aNormalizedField, | ||
foo: "normalized_foo" | ||
}; | ||
|
||
const input = { | ||
foo: "foo", | ||
normalized: aNormalizedField | ||
}; | ||
|
||
const anotherInput = { | ||
...input, | ||
normalized: aNormalizedFieldWithAlreadyExistingProperty | ||
}; | ||
describe("flattenField", () => { | ||
it("should return unmodified input if fieldToFlat is not an Object", () => { | ||
const result = flattenField(input, "foo"); | ||
expect(result).toEqual(input); | ||
}); | ||
|
||
it("should return a flattened input without renaming any field", () => { | ||
const result = flattenField(input, "normalized"); | ||
expect(result).toEqual( | ||
withoutUndefinedValues({ | ||
...input, | ||
normalized: undefined, | ||
...aNormalizedField | ||
}) | ||
); | ||
}); | ||
|
||
it("should return a flattened input with renaming fields that overlap existing input fields", () => { | ||
const result = flattenField(anotherInput, "normalized"); | ||
expect(result).toEqual( | ||
withoutUndefinedValues({ | ||
...aNormalizedFieldWithAlreadyExistingProperty, | ||
...anotherInput, | ||
normalized: undefined, | ||
normalized_foo: aNormalizedFieldWithAlreadyExistingProperty.foo | ||
}) | ||
); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import * as O from "fp-ts/Option"; | ||
import { withoutUndefinedValues } from "@pagopa/ts-commons/lib/types"; | ||
import { pipe } from "fp-ts/lib/function"; | ||
import { toJsonObject } from "../utils/data"; | ||
|
||
export const flattenField = <T>(input: T, fieldToFlat: keyof T): T => | ||
pipe( | ||
input, | ||
O.fromPredicate(stream => stream[fieldToFlat] instanceof Object), | ||
O.map(data => pipe(data[fieldToFlat], toJsonObject)), | ||
O.map(objToFlat => | ||
pipe( | ||
objToFlat, | ||
Object.keys, | ||
objectFieldNames => | ||
objectFieldNames.reduce( | ||
(acc, fieldName) => | ||
Object.keys(input).includes(fieldName) | ||
? { | ||
...acc, | ||
[`${String(fieldToFlat)}_${fieldName}`]: objToFlat[ | ||
fieldName | ||
] | ||
} | ||
: { ...acc, [fieldName]: objToFlat[fieldName] }, | ||
{} | ||
), | ||
flattenedContent => ({ ...input, ...flattenedContent }), | ||
result => | ||
withoutUndefinedValues({ | ||
...result, | ||
[fieldToFlat]: undefined | ||
}) | ||
) | ||
), | ||
O.getOrElse(() => input) | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
import * as J from "fp-ts/lib/Json"; | ||
import * as R from "fp-ts/Record"; | ||
|
||
export const toJsonObject = (jsonData: J.Json): Record<string, unknown> => | ||
export const toJsonObject = (jsonData: unknown): Record<string, unknown> => | ||
R.fromEntries(Object.entries(jsonData)); |