Merge branch 'main' into user_npmrc

.github/workflows/clang-format.yml

@@ -48,11 +48,12 @@ jobs:
       - name: Install LLVM
         run: |
           curl -fsSL https://apt.llvm.org/llvm.sh | sudo bash -s -- ${{ env.LLVM_VERSION_MAJOR }} all
-          sudo apt-get update
-          sudo apt-get install -y ninja-build ccache
-      - name: Format
+      - name: Clang Format
+        env:
+          ENABLE_CCACHE: OFF
+          LLVM_VERSION: ${{ env.LLVM_VERSION }}
         run: |
-          bun run clang-format -DLLVM_VERSION=${{ env.LLVM_VERSION }}
+          bun run clang-format:diff
       - name: Commit
         uses: stefanzweifel/git-auto-commit-action@v5
         with:

.github/workflows/clang-tidy.yml

@@ -0,0 +1,60 @@
+name: clang-tidy
+
+permissions:
+  contents: write
+
+on:
+  workflow_call:
+  workflow_dispatch:
+  pull_request:
+    paths:
+      - ".github/workflows/clang-tidy.yml"
+      - ".clang-tidy"
+      - "package.json"
+      - "scripts/**"
+      - "cmake/**"
+      - "src/**/*.c"
+      - "src/**/*.cpp"
+      - "src/**/*.h"
+      - "packages/**/*.c"
+      - "packages/**/*.cpp"
+      - "packages/**/*.h"
+
+env:
+  BUN_VERSION: "1.1.27"
+  LLVM_VERSION: "18.1.8"
+  LLVM_VERSION_MAJOR: "18"
+
+jobs:
+  clang-tidy:
+    name: clang-tidy
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          sparse-checkout: |
+            .github
+            .clang-tidy
+            package.json
+            scripts
+            cmake
+            src
+            packages
+      - name: Setup Bun
+        uses: ./.github/actions/setup-bun
+        with:
+          bun-version: ${{ env.BUN_VERSION }}
+      - name: Install LLVM
+        run: |
+          curl -fsSL https://apt.llvm.org/llvm.sh | sudo bash -s -- ${{ env.LLVM_VERSION_MAJOR }} all
+      - name: Clang Tidy
+        env:
+          ENABLE_CCACHE: OFF
+          LLVM_VERSION: ${{ env.LLVM_VERSION }}
+        run: |
+          bun run clang-tidy:diff
+      - name: Commit
+        uses: stefanzweifel/git-auto-commit-action@v5
+        with:
+          commit_message: "`bun run clang-tidy`"

.github/workflows/prettier-format.yml

@@ -37,9 +37,12 @@ jobs:
       - name: Setup Dependencies
         run: |
           bun install
-      - name: Format
+      - name: Prettier Format
+        env:
+          ENABLE_CCACHE: OFF
+          SKIP_LLVM: ON
         run: |
-          bun run prettier:extra
+          bun run prettier:diff
       - name: Commit
         uses: stefanzweifel/git-auto-commit-action@v5
         with:

.github/workflows/zig-format.yml

@@ -37,8 +37,11 @@ jobs:
         with:
           bun-version: ${{ env.BUN_VERSION }}
       - name: Zig Format
+        env:
+          ENABLE_CCACHE: OFF
+          SKIP_LLVM: ON
         run: |
-          bun run zig-format -DENABLE_CCACHE=OFF -DSKIP_LLVM=ON
+          bun run zig-format:diff
       - name: Commit
         uses: stefanzweifel/git-auto-commit-action@v5
         with:

.vscode/settings.json

@@ -52,12 +52,15 @@
   "cmake.configureOnOpen": false,
   "C_Cpp.errorSquiggles": "enabled",
   "[cpp]": {
+    "editor.tabSize": 4,
     "editor.defaultFormatter": "xaver.clang-format",
   },
   "[c]": {
+    "editor.tabSize": 4,
     "editor.defaultFormatter": "xaver.clang-format",
   },
   "[h]": {
+    "editor.tabSize": 4,
     "editor.defaultFormatter": "xaver.clang-format",
   },
   "clangd.arguments": ["-header-insertion=never"],

CMakeLists.txt

@@ -30,6 +30,7 @@ include(CompilerFlags)
 
 # --- Tools ---
 
+include(SetupGit)
 include(SetupBuildkite)
 include(SetupBun)
 include(SetupEsbuild)
@@ -43,4 +44,6 @@ include(BuildBun)
 # --- Analysis ---
 
 include(RunClangFormat)
+include(RunClangTidy)
 include(RunZigFormat)
+include(RunPrettier)

cmake/Globals.cmake

@@ -124,12 +124,19 @@ optionx(CACHE_STRATEGY "read-write|read-only|write-only|none" "The strategy to u
 optionx(CI BOOL "If CI is enabled" DEFAULT OFF)
 
 if(CI)
-  set(DEFAULT_VENDOR_PATH ${CACHE_PATH}/vendor)
+  set(WARNING FATAL_ERROR)
 else()
-  set(DEFAULT_VENDOR_PATH ${CWD}/vendor)
+  set(WARNING WARNING)
 endif()
 
-optionx(VENDOR_PATH FILEPATH "The path to the vendor directory" DEFAULT ${DEFAULT_VENDOR_PATH})
+# TODO: This causes flaky zig builds in CI, so temporarily disable it.
+# if(CI)
+#   set(DEFAULT_VENDOR_PATH ${CACHE_PATH}/vendor)
+# else()
+#   set(DEFAULT_VENDOR_PATH ${CWD}/vendor)
+# endif()
+
+optionx(VENDOR_PATH FILEPATH "The path to the vendor directory" DEFAULT ${CWD}/vendor)
 optionx(TMP_PATH FILEPATH "The path to the temporary directory" DEFAULT ${BUILD_PATH}/tmp)
 
 optionx(FRESH BOOL "Set when --fresh is used" DEFAULT OFF)

cmake/analysis/RunClangFormat.cmake

@@ -1,3 +1,5 @@
+# https://clang.llvm.org/docs/ClangFormat.html
+
 find_command(
   VARIABLE
     CLANG_FORMAT_PROGRAM
@@ -35,3 +37,35 @@ register_command(
       ${CLANG_FORMAT_SOURCES}
   ALWAYS_RUN
 )
+
+if(GIT_CHANGED_SOURCES)
+  set(CLANG_FORMAT_CHANGED_SOURCES)
+  foreach(source ${CLANG_FORMAT_SOURCES})
+    list(FIND GIT_CHANGED_SOURCES ${source} index)
+    if(NOT ${index} EQUAL -1)
+      list(APPEND CLANG_FORMAT_CHANGED_SOURCES ${source})
+    endif()
+  endforeach()
+endif()
+
+if(CLANG_FORMAT_CHANGED_SOURCES)
+  set(CLANG_FORMAT_DIFF_COMMAND ${CLANG_FORMAT_PROGRAM}
+    -i # edits files in-place
+    --verbose
+    ${CLANG_FORMAT_CHANGED_SOURCES}
+  )
+else()
+  set(CLANG_FORMAT_DIFF_COMMAND ${CMAKE_COMMAND} -E echo "No changed files for clang-format")
+endif()
+
+register_command(
+  TARGET
+    clang-format-diff
+  COMMENT
+    "Running clang-format on changed files"
+  COMMAND
+    ${CLANG_FORMAT_DIFF_COMMAND}
+  CWD
+    ${BUILD_PATH}
+  ALWAYS_RUN
+)