fix memory leak in Bun.shellEscape return value (#14130)

oven-sh · Sep 26, 2024 · 7b058e2 · 7b058e2
1 parent ec7078a
commit 7b058e2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/bun.js/api/BunObject.zig b/src/bun.js/api/BunObject.zig
@@ -435,7 +435,8 @@ pub fn shellEscape(
                 globalThis.throw("String has invalid utf-16: {s}", .{bunstr.byteSlice()});
                 return .undefined;
             }
-            return bun.String.createUTF8(outbuf.items[0..]).toJS(globalThis);
+            var str = bun.String.createUTF8(outbuf.items[0..]);
+            return str.transferToJS(globalThis);
         }
         return jsval;
     }
@@ -445,7 +446,8 @@ pub fn shellEscape(
             globalThis.throwOutOfMemory();
             return .undefined;
         };
-        return bun.String.createUTF8(outbuf.items[0..]).toJS(globalThis);
+        var str = bun.String.createUTF8(outbuf.items[0..]);
+        return str.transferToJS(globalThis);
     }
 
     return jsval;