Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookbook: Docs for Feedback Dialog/Message #16651

Merged
merged 7 commits into from
Sep 13, 2024

Merge branch 'documentation/57632-use-feedbackdialog-component-in-cor…

2b62c25
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Lookbook: Docs for Feedback Dialog/Message #16651

Merge branch 'documentation/57632-use-feedbackdialog-component-in-cor…
2b62c25
Select commit
Loading
Failed to load commit list.
GitHub Actions / rubocop succeeded Sep 13, 2024 in 1s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (24)

app/helpers/application_helper.rb|46 col 50| Do not use instance variables in helpers.
app/helpers/application_helper.rb|91 col 5| Prefer string interpolation to string concatenation.
app/helpers/application_helper.rb|114 col 27| Do not use Date.today without zone. Use Time.zone.today instead.
app/helpers/application_helper.rb|115 col 59| Do not use Date.today without zone. Use Time.zone.today instead.
app/helpers/application_helper.rb|126 col 3| Assignment Branch Condition size for project_nested_ul is too high. [<3, 23, 6> 23.96/17]
app/helpers/application_helper.rb|147 col 7| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|156 col 3| Assignment Branch Condition size for labeled_check_box_tags is too high. [<8, 22, 3> 23.6/17]
app/helpers/application_helper.rb|172 col 14| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|208 col 43| Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
app/helpers/application_helper.rb|209 col 8| Do not use instance variables in helpers.
app/helpers/application_helper.rb|209 col 8| Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/helpers/application_helper.rb|209 col 21| Do not use instance variables in helpers.
app/helpers/application_helper.rb|212 col 35| Do not use instance variables in helpers.
app/helpers/application_helper.rb|225 col 43| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|262 col 17| Method parameter must be at least 3 characters long.
app/helpers/application_helper.rb|273 col 31| Prefer keyword arguments for arguments with a boolean default value; use blank: true instead of blank = true.
app/helpers/application_helper.rb|293 col 5| Useless assignment to variable - options.
app/helpers/application_helper.rb|339 col 5| Prefer string interpolation to string concatenation.
app/helpers/application_helper.rb|377 col 21| Prefer keyword arguments for arguments with a boolean default value; use checked: true instead of checked = true.
app/helpers/application_helper.rb|437 col 54| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|468 col 9| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|468 col 13| Prefer string interpolation to string concatenation.
app/helpers/application_helper.rb|469 col 10| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|469 col 14| Prefer string interpolation to string concatenation.