Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookbook: Docs for Feedback Dialog/Message #16651

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

psatyal
Copy link
Contributor

@psatyal psatyal commented Sep 6, 2024

Ticket

https://community.openproject.org/projects/openproject/work_packages/57632/activity

What are you trying to accomplish?

Contribute documentation for the Feedback Dialog (and containing Feedback Message) components to our Primer Lookbook.

What approach did you choose and why?

Text. I thought song and lyrics would be overkill.

Merge checklist

  • Add draft of documentation in Lookbook (patterns, previews, etc)
  • Henriette reviews
  • Ready for merge

@psatyal psatyal requested a review from HDinger September 6, 2024 14:52
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @psatyal

I added the previews and some technical notes.

@HDinger HDinger force-pushed the documentation/57632-use-feedbackdialog-component-in-core branch from bf3325a to abc46db Compare September 13, 2024 06:28
@HDinger HDinger merged commit adfd3d7 into dev Sep 13, 2024
10 of 11 checks passed
@HDinger HDinger deleted the documentation/57632-use-feedbackdialog-component-in-core branch September 13, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants