-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lookbook: Docs for Feedback Dialog/Message #16651
Merged
HDinger
merged 7 commits into
dev
from
documentation/57632-use-feedbackdialog-component-in-core
Sep 13, 2024
Merged
Lookbook: Docs for Feedback Dialog/Message #16651
HDinger
merged 7 commits into
dev
from
documentation/57632-use-feedbackdialog-component-in-core
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDinger
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @psatyal
I added the previews and some technical notes.
lookbook/docs/patterns/13-feedback-dialog-and-feedback-message.md.erb
Outdated
Show resolved
Hide resolved
lookbook/docs/patterns/13-feedback-dialog-and-feedback-message.md.erb
Outdated
Show resolved
Hide resolved
lookbook/docs/patterns/13-feedback-dialog-and-feedback-message.md.erb
Outdated
Show resolved
Hide resolved
lookbook/docs/patterns/13-feedback-dialog-and-feedback-message.md.erb
Outdated
Show resolved
Hide resolved
HDinger
force-pushed
the
documentation/57632-use-feedbackdialog-component-in-core
branch
from
September 13, 2024 06:28
bf3325a
to
abc46db
Compare
HDinger
approved these changes
Sep 13, 2024
…e' of https://github.com/opf/openproject into documentation/57632-use-feedbackdialog-component-in-core
HDinger
deleted the
documentation/57632-use-feedbackdialog-component-in-core
branch
September 13, 2024 08:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/openproject/work_packages/57632/activity
What are you trying to accomplish?
Contribute documentation for the Feedback Dialog (and containing Feedback Message) components to our Primer Lookbook.
What approach did you choose and why?
Text. I thought song and lyrics would be overkill.
Merge checklist