Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[57686] Notification center split screen: tab nav is hidden behind the top banner #16648

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[57686] Notification center split screen: tab nav is hidden behind the top banner #16648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/components/work_packages/split_view_component.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,7 @@
@media screen and (max-width: $breakpoint-lg)
// Unfortunately, we have to enforce this style via !important as the resizer writes the width directly on the element as inline style
min-width: unset !important

@media screen and (max-width: $breakpoint-sm)
.work-packages--details-toolbar-container
@include hide-button-texts
2 changes: 1 addition & 1 deletion frontend/src/app/features/work-packages/components/wp-details/wp-details-toolbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

wpSingleContextMenu
[wpSingleContextMenu-workPackage]="workPackage">
<span class="button--text" [textContent]="text.button_more"></span>
<span class="button--text button--text_without_icon" [textContent]="text.button_more"></span>
<op-icon icon-classes="button--dropdown-indicator"></op-icon>
</button>
</div>
2 changes: 1 addition & 1 deletion frontend/src/global_styles/layout/_toolbar_mobile.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
margin: 0 0 0 10px

// Hide toolbar button texts on mobile
.button--text:not(.button--text_without_icon),
@include hide-button-texts
.icon-pulldown,
.spot-icon_dropdown
display: none
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/global_styles/openproject/_mixins.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,9 @@ $scrollbar-size: 10px
font: inherit
text-align: inherit

@mixin hide-button-texts
.button--text:not(.button--text_without_icon)
display: none

@mixin board-header-editable-toolbar-title
line-height: normal !important
Expand Down