Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[57686] Notification center split screen: tab nav is hidden behind the top banner #16648

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Sep 6, 2024

Ticket

https://community.openproject.org/projects/openproject/work_packages/57686/activity

What are you trying to accomplish?

Avoid that the bottom bar has a line break on mobile which breaks the layout as it pushes the content to the top and thus behind the app header

Screenshots

Bildschirmfoto 2024-09-06 um 14 02 26

After
Bildschirmfoto 2024-09-06 um 13 59 01

… layout as it pushes the content to the top and thus behind the app header
@HDinger HDinger added this to the 14.5.x milestone Sep 6, 2024
@HDinger HDinger requested a review from a team September 6, 2024 12:18
@HDinger HDinger changed the title Notification tabs are behind the app header (mobile) [57686] Notification center split screen: tab nav is hidden behind the top banner Sep 6, 2024
Copy link
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine on mobile firefox and safari 👍

@oliverguenther oliverguenther merged commit 15cbc63 into release/14.5 Sep 9, 2024
12 checks passed
@oliverguenther oliverguenther deleted the fix/mobile-overlapping branch September 9, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants