handle endchar command with seac parameters (standard encoding accented characters) #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connum
added
bug
Spec
This was referenced Oct 31, 2023
Connum
force-pushed
the
fix/117-seac-endchar
branch
from
d32bd6f
to
4fdba0c
Compare
yne
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added handling of the
endcharcommand withseac-parameters in CFF fonts.See The Type 2 Charstring Format spec section "Appendix C: Compatibility and Deprecated Operators" (page 35)
https://adobe-type-tools.github.io/font-tech-notes/pdfs/5177.Type2.pdf
and Adobe Type 1 Font Format spec (page 50)
https://adobe-type-tools.github.io/font-tech-notes/pdfs/T1_SPEC.pdf
Motivation and Context
fix #117 (composite glyphs having no path)
How Has This Been Tested?
Loaded
AbrilFatface-Regular.otfwith the Glyph Inspector to make sure that all composite glyphs are rendered correctlyScreenshots (if appropriate):
before (note empty glyphs 202, 204, ... 291, 293, 295, 299)
after
and composition information for glyph 299
The newly added test case for this in the unicode test tool passing:
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).