Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for seac-like endchar command #77

Closed
Connum opened this issue Oct 31, 2023 · 3 comments · Fixed by #86
Closed

test for seac-like endchar command #77

Connum opened this issue Oct 31, 2023 · 3 comments · Fixed by #86

Comments

@Connum
Copy link

Connum commented Oct 31, 2023

I just fixed a bug in opentype.js that could make for a new test case, see opentypejs/opentype.js#633
The CFF endchar command supports a compatibility to the Type 1 seac command in order to implement standard encoding accented characters. This seems to also affect fontkit and it would help to be caught for other parsers/renderers as well.

@brawer
Copy link
Collaborator

brawer commented Oct 31, 2023

Can you prepare a test font with just one or two glyphs? I'll then add a test case to the test suite.

@behdad
Copy link
Contributor

behdad commented Oct 31, 2023

Can you prepare a test font with just one or two glyphs? I'll then add a test case to the test suite.

https://github.com/harfbuzz/harfbuzz/blob/main/test/api/fonts/cff1_seac.otf

@Connum
Copy link
Author

Connum commented Oct 31, 2023

Nice, that was fast! The harfbuzz test fonts are licensed under SIL Open Font License V1.1, so you can use them for the test suite.

brawer added a commit that referenced this issue Nov 1, 2023
The font is a derivative of Adobe Source Sans Pro, equally under
OFL-1.1 license. Taken from the HarfBuzz test suite, but using a
different font name to comply with the OFL licensing terms.

#77
brawer added a commit that referenced this issue Nov 1, 2023
The font is a derivative of Adobe Source Sans Pro, equally under
OFL-1.1 license. Taken from the HarfBuzz test suite, but using a
different font name to comply with the OFL licensing terms.

#77
brawer added a commit that referenced this issue Nov 1, 2023
Not updating test reports for the native rendering stacks because
our C++ codebase cannot be compiled anymore with current clang (15.0.0).
This is a separate issue, independent of testing CFF fonts.

Fixes #77

Related:
* foliojs/fontkit#322
* opentypejs/opentype.js#117
@brawer brawer closed this as completed in #86 Nov 1, 2023
brawer added a commit that referenced this issue Nov 1, 2023
Not updating test reports for the native rendering stacks because
our C++ codebase cannot be compiled anymore with current clang (15.0.0).
This is a separate issue, independent of testing CFF fonts.

Fixes #77

Related:
* foliojs/fontkit#322
* opentypejs/opentype.js#117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants