Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OSD docker cgroup params with ops params #5114

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Update OSD docker cgroup params with ops params

Issues Resolved

Closes #5000

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi
Copy link
Collaborator

Thanks @peterzhuamazon, approved and I assume the flags are safe to replace even for 1.x versions.

@peterzhuamazon
Copy link
Member Author

Thanks @peterzhuamazon, approved and I assume the flags are safe to replace even for 1.x versions.

Yes @prudhvigodithi I confirmed those params are used in 1.3 version of OpenSearch:
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/1.3/src/dev/build/tasks/os_packages/docker_generator/resources/bin/opensearch-dashboards-docker#L181

@peterzhuamazon peterzhuamazon merged commit d43ad38 into opensearch-project:main Oct 17, 2024
11 checks passed
@peterzhuamazon peterzhuamazon deleted the docker-release-cgroup branch October 17, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Docker instances yield two deprecation warnings related to cgroup
2 participants