Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Docker instances yield two deprecation warnings related to cgroup #5000

Closed
CarterPape opened this issue Sep 6, 2024 · 5 comments · Fixed by #5114
Closed

Comments

@CarterPape
Copy link

Describe the bug

On startup, Docker instances of OpenSearch Dashboards will throw deprecation warnings about cpu.cgroup.path.override and cpuacct.cgroup.path.override, unless the user has overridden the default entrypoint scripts.

To reproduce

Launch a vanilla Docker image of OpenSearch Dashboards with the following:

docker pull opensearchproject/opensearch-dashboards:latest
docker run -it -p 5601:5601  --name opensearch-dashboard opensearchproject/opensearch-dashboards:latest

The dashboard will fail to connect to the cluster, but the deprecation warning gets thrown before this. Even when properly configured with docker-compose.yml and connected to a cluster, the dashboard will throw the deprecation warnings because the deprecated settings are set in the Docker entrypoint script (e.g. docker/release/config/opensearch-dashboards/opensearch-dashboards-docker-entrypoint-default.x.sh).

Expected behavior

No deprecation warning expected.

Screenshots

No response

Host / Environment

Latest Docker image located at https://hub.docker.com/r/opensearchproject/opensearch-dashboards
(build date 2024-08-15T20:09:22Z)

Additional context

No response

Relevant log output

opensearch-dashboards  | {"type":"log","@timestamp":"2024-09-06T02:17:39Z","tags":["warning","config","deprecation"],"pid":1,"message":"\"cpu.cgroup.path.override\" is deprecated and has been replaced by \"ops.cGroupOverrides.cpuPath\""}
opensearch-dashboards  | {"type":"log","@timestamp":"2024-09-06T02:17:39Z","tags":["warning","config","deprecation"],"pid":1,"message":"\"cpuacct.cgroup.path.override\" is deprecated and has been replaced by \"ops.cGroupOverrides.cpuAcctPath\""}
@CarterPape CarterPape added bug Something isn't working untriaged Issues that have not yet been triaged labels Sep 6, 2024
@prudhvigodithi
Copy link
Collaborator

prudhvigodithi commented Sep 12, 2024

[Triage]
Need to update the opensearch-dashboards-docker-entrypoint https://github.com/opensearch-project/opensearch-build/blob/main/docker/release/config/opensearch-dashboards/opensearch-dashboards-docker-entrypoint-2.x.sh file to replace the deprecated flags with the supported ones. @ashwin-pc can you please add some more details here is it safe to completely replace the deprecated flags ?
Thanks
@peterzhuamazon

@prudhvigodithi prudhvigodithi added enhancement New Enhancement question Further information is requested and removed bug Something isn't working untriaged Issues that have not yet been triaged labels Sep 12, 2024
@prudhvigodithi
Copy link
Collaborator

Adding @AMoo-Miki @kavilla.

@AMoo-Miki
Copy link
Contributor

@prudhvigodithi OSD uses ops.cGroupOverrides.cpuPath and ops.cGroupOverrides.cpuAcctPath. This seems to predate the forking of OSD and as such it should be safe to replace.

@prudhvigodithi
Copy link
Collaborator

Got it thanks Miki, adding @peterzhuamazon @getsaurabh02.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Oct 16, 2024

Thanks @AMoo-Miki ,

I will go ahead and do a replacement and ready for 2.18.

@peterzhuamazon peterzhuamazon self-assigned this Oct 16, 2024
@peterzhuamazon peterzhuamazon added docker Build Libraries & Interfaces and removed question Further information is requested labels Oct 16, 2024
@peterzhuamazon peterzhuamazon changed the title [Bug]: Docker instances yield two deprecation warnings related to cgroup [Enhancement]: Docker instances yield two deprecation warnings related to cgroup Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants