Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if security plugin exists in startup script #3728

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

rishabh6788
Copy link
Collaborator

Description

There are certain cases when a distribution build is built without security plugin. In that case when opensearch-tar-install.sh script is run to start the OS process it fails at this line as there is no opensearch-security plugin present in the bundle.
To overcome this adding a simple condition to check whether opensearch-security plugin exists in the bundle.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #3728 (ec46337) into main (420a9a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3728   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         182      182           
  Lines        5420     5420           
=======================================
  Hits         4962     4962           
  Misses        458      458           

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offline talk with @rishabh6788 confirms linux work and also test on Windows runs on my machine.

Thanks.

@rishabh6788 rishabh6788 merged commit 4b297fd into opensearch-project:main Jul 12, 2023
12 checks passed
@gaiksaya
Copy link
Member

Thanks for fixing this @rishabh6788 Great step for making all RC candidates executable. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants