Inline the header svg

Ideally we wouldn't have to pull down this file on every load, and we could just inline it. This commit implements inlining. Note, that this requires a minor modification to the unit test, as the inline header remains when unit tests are run. It's not clear at this time how to make inlining plugin operate on unit tests, but it doesn't seem terribly important. Tested: Loading the webui no longer shows a download of logo-header Change-Id: Iaa5be5b5a84e0ad6e1f430113f929032835c9f1c Signed-off-by: Ed Tanous <[email protected]>
openbmc · Apr 24, 2024 · 51abe87 · 51abe87
1 parent 515f465
commit 51abe87
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/components/AppHeader/AppHeader.vue b/src/components/AppHeader/AppHeader.vue
@@ -36,6 +36,7 @@
             data-test-id="appHeader-container-overview"
           >
             <img
+              svg-inline
               class="header-logo"
               src="@/assets/images/logo-header.svg"
               :alt="altLogo"

diff --git a/tests/unit/__snapshots__/AppHeader.spec.js.snap b/tests/unit/__snapshots__/AppHeader.spec.js.snap
@@ -57,6 +57,7 @@ exports[`AppHeader.vue should render correctly 1`] = `
             alt="Built on OpenBMC"
             class="header-logo"
             src="@/assets/images/logo-header.svg"
+            svg-inline=""
           />
         </b-navbar-brand>