Skip to content

Commit

Permalink
Remove /subscribe websocket handler
Browse files Browse the repository at this point in the history
Having this code is causing crashes for implementations that don't have
dbus-rest enabled in bmcweb, which is deprecated.  This commit is
intended to start a discussion around this issue, and propose simply
removing it.

33a8c53 (checked in July 2020) points
this crash out, and adds a way to disable the feature.  While we could
just make VUE_APP_SUBSCRIBE_SOCKET_DISABLED the default, this seems ill
advised, given the dbus-rest options deprecated status.

Change-Id: I6244f5e2ce895199d5d47cfca9eef36584e8f524
Signed-off-by: Ed Tanous <[email protected]>
  • Loading branch information
edtanous committed Apr 20, 2024
1 parent d1ef18e commit 515f465
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 63 deletions.
1 change: 0 additions & 1 deletion .env.intel
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ NODE_ENV=production
VUE_APP_ENV_NAME="intel"
VUE_APP_COMPANY_NAME="intel"
VUE_APP_GUI_NAME="BMC System Management"
VUE_APP_SUBSCRIBE_SOCKET_DISABLED="true"
VUE_APP_SWITCH_TO_BACKUP_IMAGE_DISABLED="true"
VUE_APP_MODIFY_SSH_POLICY_DISABLED="true"
VUE_APP_VIRTUAL_MEDIA_LIST_ENABLED="true"
Expand Down
2 changes: 0 additions & 2 deletions src/store/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import FactoryResetStore from './modules/Operations/FactoryResetStore';
import SnmpAlertsStore from './modules/Settings/SnmpAlertsStore';
import KeyClearStore from './modules/Operations/KeyClearStore';

import WebSocketPlugin from './plugins/WebSocketPlugin';
import DateTimeStore from './modules/Settings/DateTimeStore';
import VirtualMediaStore from './modules/Operations/VirtualMediaStore';

Expand Down Expand Up @@ -74,5 +73,4 @@ export default new Vuex.Store({
factoryReset: FactoryResetStore,
keyClear: KeyClearStore,
},
plugins: [WebSocketPlugin],
});
60 changes: 0 additions & 60 deletions src/store/plugins/WebSocketPlugin.js

This file was deleted.

0 comments on commit 515f465

Please sign in to comment.