-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Misc logs fixes #1697
Merged
Merged
test: Misc logs fixes #1697
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7ea96b5
test: Add LogRecordProcessor tests
kaylareopelle 99a5e23
test: Update observed_timestamp LogRecord test
kaylareopelle ee67e9f
test: Exclude test directory from SimpleCov
kaylareopelle 138da50
style: Misc docs/spacing updates
kaylareopelle dab04d7
Merge branch 'main' into misc-logs-fixes
kaylareopelle 1db5a54
Merge branch 'main' into misc-logs-fixes
kaylareopelle 732529e
Merge branch 'main' into misc-logs-fixes
mwear 29d9bd0
test: Skip flaky JRuby test with link to fix issue
kaylareopelle 1be14ee
Merge branch 'misc-logs-fixes' of github.com:kaylareopelle/openteleme…
kaylareopelle e2e9db7
Merge branch 'main' into misc-logs-fixes
mwear 7b0da99
Merge branch 'main' into misc-logs-fixes
mwear File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
logs_sdk/test/opentelemetry/sdk/logs/log_record_processor_test.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# frozen_string_literal: true | ||
|
||
# Copyright The OpenTelemetry Authors | ||
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
require 'test_helper' | ||
|
||
describe OpenTelemetry::SDK::Logs::LogRecordProcessor do | ||
let(:processor) { OpenTelemetry::SDK::Logs::LogRecordProcessor.new } | ||
let(:log_record) { nil } | ||
let(:context) { nil } | ||
|
||
it 'implements #on_emit' do | ||
processor.on_emit(log_record, context) | ||
end | ||
|
||
it 'implements #force_flush' do | ||
processor.force_flush | ||
end | ||
|
||
it 'returns a success code when #force_flush is called' do | ||
assert(OpenTelemetry::SDK::Logs::Export::SUCCESS, processor.force_flush) | ||
end | ||
|
||
it 'implements #shutdown' do | ||
processor.shutdown | ||
end | ||
|
||
it 'returns a success code when #shutdown is called' do | ||
assert(OpenTelemetry::SDK::Logs::Export::SUCCESS, processor.shutdown) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwear - Until I can put in a real fix, I think we should skip this test for JRuby. Does that sound good to you?