-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Misc logs fixes #1697
test: Misc logs fixes #1697
Conversation
Tests for timestamp were updated to use Time objects, but observed_timestamp was not. Now, they both evaluate Time. They are turned into floats when converted to LogRecordData.
I'm still noticing occasional flakes similar to:
Here's an example: https://github.com/open-telemetry/opentelemetry-ruby/actions/runs/10605899311/job/29434936693?pr=1697 Were any of these fixes expected to address this? |
…try-ruby into misc-logs-fixes
# This will be fixed as part of Issue #1701 | ||
# https://github.com/open-telemetry/opentelemetry-ruby/issues/1701 | ||
skip if RUBY_ENGINE == 'jruby' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwear - Until I can put in a real fix, I think we should skip this test for JRuby. Does that sound good to you?
Fixes a few things from previously merged logs content:
observed_timestamp was not. Now, they both evaluate Time. They are turned into floats when converted to LogRecordData.)
test: Exclude test directory from SimpleCov (this leads to more accurate coverage percentages)
style: Misc docs/spacing updates