Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Misc logs fixes #1697

Merged
merged 11 commits into from
Sep 4, 2024
Merged

Conversation

kaylareopelle
Copy link
Contributor

Fixes a few things from previously merged logs content:

kaylareopelle and others added 5 commits August 28, 2024 11:52
Tests for timestamp were updated to use Time objects, but
observed_timestamp was not. Now, they both evaluate Time.
They are turned into floats when
converted to LogRecordData.
@mwear
Copy link
Member

mwear commented Aug 30, 2024

I'm still noticing occasional flakes similar to:

  1) Error:
OpenTelemetry::SDK::Logs::Export::BatchLogRecordProcessor::#on_emit#test_0003_logs a warning if a log record was emitted after the buffer is full:
MockExpectationError: expected warn("1 log record(s) dropped. Reason: buffer-full") => nil
    org/jruby/RubyHash.java:1615:in `each'
    test/opentelemetry/sdk/logs/export/batch_log_record_processor_test.rb:220:in `block in <main>'
    org/jruby/RubyArray.java:1981:in `each'
    org/jruby/RubyArray.java:2803:in `map'

Here's an example: https://github.com/open-telemetry/opentelemetry-ruby/actions/runs/10605899311/job/29434936693?pr=1697

Were any of these fixes expected to address this?

@kaylareopelle
Copy link
Contributor Author

I'm still noticing occasional flakes similar to ... Were any of these fixes expected to address this?

@mwear - These fixes weren't intended to address the flakes. I'm planning to take care of those with #1701 and will work on that later this week.

Comment on lines +207 to +210
# This will be fixed as part of Issue #1701
# https://github.com/open-telemetry/opentelemetry-ruby/issues/1701
skip if RUBY_ENGINE == 'jruby'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwear - Until I can put in a real fix, I think we should skip this test for JRuby. Does that sound good to you?

@mwear mwear merged commit 3ff81bd into open-telemetry:main Sep 4, 2024
60 checks passed
@kaylareopelle kaylareopelle deleted the misc-logs-fixes branch September 4, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants