libobs-d3d11: Allow for arbitrary marker name lengths #11328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using _malloca to allocate memory on the stack, we can allow for marker names well in excess of 63 wide characters like before. In testing this had no measurable negative performance impact, which should mean that it is working as intended. This will fall back to the old behavior if /EH is completely disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows using arbitrary marker name lengths with libobs-d3d11.
Motivation and Context
When
gs_debug_marker_beginis provided with a utf8 string that happens to exceeds 64 wchar_t's, the debug marker would have no name at all.How Has This Been Tested?
I've compiled and tested this on Windows 10 22H2 with Microsoft Visual Studio 2022 (C++) on the
30.2.3tag, asmasteris not buildable locally due to over 600 "already defined in" errors from Qt MOC files. Dunno what's causing them, tried a completely clean clone and it still happens.I was unable to measure any noticable performance impact with stock plugins, not even with
#define GS_USE_DEBUG_MARKERS 1. The expected behavior of being able to use arbitrarily long marker names also worked just fine, with the longest tested being just around 4k characters long.Types of changes
Checklist: