Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allen JSON structuregraph to OWL converter (unreasoned) #12

Merged
merged 27 commits into from
Jul 7, 2022
Merged

Allen JSON structuregraph to OWL converter (unreasoned) #12

merged 27 commits into from
Jul 7, 2022

Conversation

hkir-dev
Copy link
Contributor

@hkir-dev hkir-dev commented Mar 8, 2022

#9

@hkir-dev hkir-dev requested a review from shawntanzk March 9, 2022 08:52
@hkir-dev hkir-dev mentioned this pull request Mar 9, 2022
Open
@shawntanzk shawntanzk mentioned this pull request Mar 9, 2022
Closed
@shawntanzk
Copy link
Collaborator

Notes on diffs:

  1. weird "in-old-not-new" meyer's loop of optic radiation seem to be in both and alright -> not sure why R code is picking this up
  2. some changes point more accurately:
    lateral mammillary nucleus in old points to brainstem nucleus, in new points to lateral mammillary nucleus
  3. many terms mapped to brainstem nucleus seem to have changed to regional part of brain:
    eg anterodorsal nucleus of thalamus, lateral mammillary nucleus, paracentral nucleus
  4. parts mapped correctly in old change wrongly:
    gray matter was mapped to brain gray matter in old, but changed to regional part of brain. similar for cerebellar commissure, hippocampus
  5. ventral commissure of the spinal cord mapped wrongly differently in both old and new: brain commisure to regional part of brain
  6. Parvi -> parvo (changes just cause of uberon)

Overall: not really sure if turning off reasoning helped at all

@shawntanzk shawntanzk changed the title Allen JSON structuregraph to OWL converter Allen JSON structuregraph to OWL converter (unreasoned) Mar 11, 2022
@shawntanzk shawntanzk merged commit 8186422 into master Jul 7, 2022
@hkir-dev hkir-dev deleted the issue_9 branch August 31, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawntanzk shawntanzk Awaiting requested review from shawntanzk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hkir-dev @shawntanzk