[CI] Update cpp-linter ci (false file-annotations) #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonghakPark
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong and
helloahn
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2464. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
DonghakPark
requested review from
kparichay,
gichan-jang,
anyj0527,
zhoonit,
lhs8928,
songgot,
jihochu,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20,
EunjuYang and
a team
as code owners
DonghakPark
force-pushed
the
update_cpplinter_ci
branch
2 times, most recently
from
e60424c
to
0bc3ebe
Compare
DonghakPark
force-pushed
the
update_cpplinter_ci
branch
3 times, most recently
from
0d378ed
to
def40ad
Compare
For now we use cpp-linter as option 'file-annotations' but there is too many annotations and that make hard to read code So make false file-annotations & replace that to step-summary - fix typo for check cpp-linter exec ref : https://github.com/marketplace/actions/c-c-linter **Changes proposed in this PR:** - modified: .github/workflows/cpp_linter.yml - modified: nntrainer/dataset/func_data_producer.h Resolves: - nnstreamer#2463 **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghak PARK <[email protected]>
DonghakPark
force-pushed
the
update_cpplinter_ci
branch
from
def40ad
to
0b644a3
Compare
taos-ci
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
@DonghakPark, 💯 All CI checkers are successfully verified. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we use cpp-linter as option 'file-annotations' but there is too many annotations and that make hard to read code
So make false file-annotations & replace that to step-summary
ref : https://github.com/marketplace/actions/c-c-linter
Changes proposed in this PR:
Resolves:
--> I will add nntrainer-review-bot that make comment in PR page.
--> for now you can check error/warning in action's summary page.
Self evaluation: