Skip to content

Commit

Permalink
[CI] Update cpp-linter ci (false file-annotations)
Browse files Browse the repository at this point in the history
For now we use cpp-linter as option 'file-annotations'
but there is too many annotations and that make hard to read code

So make false file-annotations & replace that to step-summary

- fix typo for check cpp-linter exec

ref : https://github.com/marketplace/actions/c-c-linter

**Changes proposed in this PR:**
- modified:   .github/workflows/cpp_linter.yml
- modified:   nntrainer/dataset/func_data_producer.h

Resolves:
- #2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
  • Loading branch information
DonghakPark committed Feb 6, 2024
1 parent ca0bf03 commit 0b644a3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/cpp_linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: cpp-linter/cpp-linter-action@v2
- uses: cpp-linter/cpp-linter-action@v2.8.0
id: linter
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
style: file
version: 16
lines-changed-only: true

file-annotations: false
step-summary: true

- name: failing fast
if: steps.linter.outputs.clang-format-checks-failed > 0
Expand Down
2 changes: 1 addition & 1 deletion nntrainer/dataset/func_data_producer.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class FuncDataProducer final : public DataProducer {
const std::string getType() const override;

/**
* @copydoc DataProducer::setProeprty(const std::vector<std::string>
* @copydoc DataProducer::setProperty(const std::vector<std::string>
* &properties)
*/
void setProperty(const std::vector<std::string> &properties) override;
Expand Down

0 comments on commit 0b644a3

Please sign in to comment.