skiplist: add monero packages #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't seem to be documented (and should be!), but for specific, maintainer-driven exclusions, you can add anywhere in the Nix file and we'll skip it; that leaves the maintainer in control. I think the skiplist is a better tool for broader exclusions where adding such a comment would be obnoxious, or packages where the decision to skip is driven by infra; what do you think? |
|
I think it makes more sense to for this case be listed here: if (hopefully when) a mechanism to bind package updates together is added, there is a direct reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
monero-gui depends on the sources of monero-cli, so they must be updated in the same pull request.
Until #29 is implemented, these will have to be updated manually.