Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monero-gui: 0.18.3.2 -> 0.18.3.3 #301678

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Apr 4, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/monero-project/monero-gui/releases.

meta.description for monero-gui is: Private, secure, untraceable currency

meta.homepage for monero-gui is: https://getmonero.org/

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0.18.3.3 with grep in /nix/store/rqvd63zmg3b36m80q9irz0b8y3chrfyd-monero-gui-0.18.3.3
  • found 0.18.3.3 in filename of file in /nix/store/rqvd63zmg3b36m80q9irz0b8y3chrfyd-monero-gui-0.18.3.3

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
monero-gui
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/rqvd63zmg3b36m80q9irz0b8y3chrfyd-monero-gui-0.18.3.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A monero-gui https://github.com/r-ryantm/nixpkgs/archive/ae5e67cea3ac7762c71e73b028211053f843b4e4.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/ae5e67cea3ac7762c71e73b028211053f843b4e4#monero-gui

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/rqvd63zmg3b36m80q9irz0b8y3chrfyd-monero-gui-0.18.3.3
ls -la /nix/store/rqvd63zmg3b36m80q9irz0b8y3chrfyd-monero-gui-0.18.3.3/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:
  • monero-gui

Maintainer pings

cc @rnhmjoj for testing.

@ofborg ofborg bot requested a review from rnhmjoj April 5, 2024 00:23
@wineee wineee merged commit 96038c2 into NixOS:master Apr 6, 2024
28 checks passed
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 6, 2024

Please don't merge these PRs without testing.
monero-gui depends on the source of monero-cli: updating just this package sources creates an inconsistency.

@wineee
Copy link
Member

wineee commented Apr 6, 2024

Sorry, I didn’t notice that an upstream submodule was packaged separately and required version consistency. I added a PR for monero-cli: #302158

upstream only changed ci (Dockerfile) and VERSION_REVISION for cmake, If you are concerned about more impact requiring more testing, please revert this PR

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 6, 2024

upstream only changed ci (Dockerfile) and VERSION_REVISION for cmake, If you are concerned about more impact requiring more testing, please revert this PR

Yes, in this case the update is very minor, so it's not a big deal.
Anyway, I've opened a PR in nixpkgs-update to prevent the bot from making more trouble in the future.

I added a PR for monero-cli: #302158

There's a submodule that also needs an update, I've opened #302162

@r-ryantm r-ryantm deleted the auto-update/monero-gui branch April 7, 2024 00:21
@wineee
Copy link
Member

wineee commented Apr 7, 2024

But the submodule doesn't seem to have changed in this upgrade:monero-project/monero@v0.18.3.2...v0.18.3.3

trezor-common keep bff7fdf in https://github.com/monero-project/monero/tree/v0.18.3.3/external

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 7, 2024

Not in the last update...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants