Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testament: don't close Process before reading exit code #1130

Merged
merged 2 commits into from
Jan 23, 2024
Merged

testament: don't close Process before reading exit code #1130

merged 2 commits into from
Jan 23, 2024

Commits on Jan 22, 2024

  1. testament: don't close Process before reading exit code 

    On platforms like Windows this would invalidate the exit code, returning
0 which would falsely signify a success.

Instead, use `defer` to make sure that the object is kept alive until
the end of scope.
    @alaviss
    alaviss committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c387556 View commit details
    Browse the repository at this point in the history

  2. testament: add comment about defer 

    Co-authored-by: Saem Ghani <[email protected]>
    @alaviss @saem
    alaviss and saem authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    019d1bd View commit details
    Browse the repository at this point in the history