testament: don't close Process before reading exit code #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On platforms like Windows this would invalidate the exit code, returning 0 which would falsely signify a success. Instead, use `defer` to make sure that the object is kept alive until the end of scope.
saem
approved these changes
Jan 22, 2024
Co-authored-by: Saem Ghani <[email protected]>
|
/merge |
|
Merge requested by: @alaviss Contents after the first section break of the PR description has been removed and preserved below:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Windows Testament now correctly captures the exit code from commands
(compile, test run, etc).
Details
On platforms like Windows closing a process before reading the exit code
invalidates the exit code, returning 0, which would falsely signify a
success.
Instead, use
deferto make sure that the object is kept alive untilthe end of scope.