Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radically cleanup the templates #87

Merged
merged 10 commits into from
Jul 28, 2023
Merged

Radically cleanup the templates #87

merged 10 commits into from
Jul 28, 2023

Commits on Jul 27, 2023

  1. Radically cleanup the templates 

    Remove all the templates, except for one.
This makes the repository quite simpler, and emphasises the fact that we
want something that just works™

We'll certainly want to add some funkier tests, but in a more principled
way, and that doesn't leak into the end-user interface.

Also removes the example for the same reason
    Théophane Hufschmitt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    897a093 View commit details
    Browse the repository at this point in the history

  2. Use a working shell for the template 

    Co-authored-by: Yuriy Taraday <[email protected]>
    @thufschmitt @YorikSar
    2 people authored and Théophane Hufschmitt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    056b02b View commit details
    Browse the repository at this point in the history

  3. Fix the test-template script

    Théophane Hufschmitt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    bb01493 View commit details
    Browse the repository at this point in the history

  4. Make sure that all the shells work by default 

    Fix the broken ones and give default arguments to the ones that require
it.

Also blacklists `NickelPkg` as it's not a shell (arguably shouldn't be
in the same record as the shells, but that's a refactoring for later)
    Théophane Hufschmitt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    413e583 View commit details
    Browse the repository at this point in the history

  5. Expose the test script as an app

    Théophane Hufschmitt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    0106649 View commit details
    Browse the repository at this point in the history

  6. Remove a dead line of code

    Théophane Hufschmitt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    2bf7686 View commit details
    Browse the repository at this point in the history

  7. Restore the example

    Théophane Hufschmitt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    2234606 View commit details
    Browse the repository at this point in the history

  8. Use nix run for the tests

    Théophane Hufschmitt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e2df93d View commit details
    Browse the repository at this point in the history

  9. Don't cd in the flake dir when running the tests 

    Let the user do it, and benefit from the shellcheck of `writeShellApplication`.
    Théophane Hufschmitt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    8deaa42 View commit details
    Browse the repository at this point in the history

  10. Avoid a fishy pushd *

    Théophane Hufschmitt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    719acd1 View commit details
    Browse the repository at this point in the history