Radically cleanup the templates #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thufschmitt
force-pushed
the
cleanup-templates
branch
2 times, most recently
from
8023ccf
to
3500038
Compare
|
(The merging is blocked since it's expecting the |
YorikSar
requested changes
Jul 5, 2023
YorikSar
reviewed
Jul 5, 2023
YorikSar
reviewed
Jul 5, 2023
YorikSar
reviewed
Jul 5, 2023
thufschmitt
force-pushed
the
cleanup-templates
branch
3 times, most recently
from
6094ac3
to
22ab96b
Compare
|
@YorikSar I've added the example back. PTAL |
thufschmitt
force-pushed
the
cleanup-templates
branch
2 times, most recently
from
071ebf0
to
99c1216
Compare
Remove all the templates, except for one. This makes the repository quite simpler, and emphasises the fact that we want something that just works™ We'll certainly want to add some funkier tests, but in a more principled way, and that doesn't leak into the end-user interface. Also removes the example for the same reason
Co-authored-by: Yuriy Taraday <[email protected]>
Fix the broken ones and give default arguments to the ones that require it. Also blacklists `NickelPkg` as it's not a shell (arguably shouldn't be in the same record as the shells, but that's a refactoring for later)
YorikSar
requested changes
Jul 27, 2023
thufschmitt
force-pushed
the
cleanup-templates
branch
2 times, most recently
from
a73b7fb
to
3506448
Compare
added 4 commits
July 27, 2023 21:59
Let the user do it, and benefit from the shellcheck of `writeShellApplication`.
thufschmitt
force-pushed
the
cleanup-templates
branch
from
3506448
to
719acd1
Compare
YorikSar
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the templates, except for one.
This makes the repository quite simpler, and emphasises the fact that we want something that just works™
We'll certainly want to add some funkier tests, but in a more principled way, and that doesn't leak into the end-user interface.
Also removes the example for the same reason.Fix #86