Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eklipse #4894

Merged
merged 1 commit into from
Feb 12, 2024
Merged

update eklipse #4894

merged 1 commit into from
Feb 12, 2024

Conversation

ramprasadn
Copy link
Contributor

PR checklist

This PR updates output filename prefix for the csv files generated by the modules.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@ramprasadn ramprasadn marked this pull request as ready for review February 11, 2024 14:09
Copy link
Contributor

@Lucpen Lucpen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramprasadn ramprasadn added this pull request to the merge queue Feb 12, 2024
Merged via the queue into nf-core:master with commit 7f265c2 Feb 12, 2024
11 checks passed
@ramprasadn ramprasadn deleted the eklipse branch February 12, 2024 08:24
jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
uådate output prefix
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
uådate output prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants