Rename metadata column from isolate_id to gisaid_epi_isl
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fields to export in acknowledgements is hardcoded in Auspice¹ so the metadata field needs to be named `gisaid_epi_isl` to be included in the acknowledgements for the seasonal flu builds. Renaming the column in our upload config to avoid having to rename it as part of the phylogenetic workflow. ¹ <https://github.com/nextstrain/auspice/blob/dae78e74d5e06303d901387adf9fe7550a7d4aa9/src/components/download/helperFunctions.js#L326>
1 task
huddlej
approved these changes
Sep 11, 2024
|
I don't think there's any rush to merge this, so I'll plan to merge after I'm back from vacation to monitor this and #178. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The fields to export in acknowledgements is hardcoded in Auspice¹ so the
metadata field needs to be named
gisaid_epi_islto be included inthe acknowledgements for the seasonal flu builds. Renaming the column
in our upload config to avoid having to rename it as part of the
phylogenetic workflow.
¹ https://github.com/nextstrain/auspice/blob/dae78e74d5e06303d901387adf9fe7550a7d4aa9/src/components/download/helperFunctions.js#L326
Related issue(s)
First step for #178
Checklist