Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GISAID isolate ID to acknowledgments download #178

Open
3 tasks done
joverlee521 opened this issue Sep 5, 2024 · 4 comments · Fixed by #180
Open
3 tasks done

Add GISAID isolate ID to acknowledgments download #178

joverlee521 opened this issue Sep 5, 2024 · 4 comments · Fixed by #180
Labels
enhancement New feature or request

Comments

@joverlee521
Copy link
Contributor

joverlee521 commented Sep 5, 2024

Flagged internally by @rneher that the acknowledgements download does not include the GISAID isolate IDs.

#138 added the HA/NA segment accessions, but we do not include the isolate ID used to link multiple segments to the same isolate. The isolate id was added to the metadata upload in #160, so it should be available in the metadata for the builds.

The fields included in the acknowledgements is hardcoded in Auspice so the field will have to be named gisaid_epi_isl.

TODOs

@joverlee521 joverlee521 added the enhancement New feature or request label Sep 5, 2024
@joverlee521
Copy link
Contributor Author

@huddlej, would it break any of your workflows to rename the fasta_fields to gisaid_epi_isl?

@joverlee521
Copy link
Contributor Author

Ah, at least the nextclade workflow is using the isolate_id field.

Maybe better to just rename isolate_id to gisaid_epi_isl within the phylogenetic workflow right before the augur export?

@huddlej
Copy link
Contributor

huddlej commented Sep 5, 2024

I don't depend on isolate_id as a field name anywhere. Since Auspice hardcodes separate fields for GISAID and GenBank accessions (without an awareness of segmented viruses), it makes sense to rename isolate_id to gisaid_epi_isl in the uploaded metadata.

Unless the Nextclade somehow depends on an isolate_id field downstream, I would just change the Nextclade workflow to use the new field name, too.

@joverlee521
Copy link
Contributor Author

Reopening because we've removed gisaid_epi_isl from metadata in #188.

This issue now depends on nextstrain/fauna#165

@joverlee521 joverlee521 reopened this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants