Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor directory expansion. #179

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Refactor directory expansion. #179

merged 1 commit into from
Sep 12, 2024

Commits on Sep 11, 2024

  1. Refactor directory expansion.

    There were three separate implementations of directory expansion spread
    across the codebase, each accepting slightly different inputs. The one
    used by `orderly_resource` operated over a single vector of paths.  The
    one used by `orderly_shared_resource` operated over a dataframe of
    `there`/`here` columns. Finally the one used by `orderly_copy_files`
    used the packet metadata to enumerate files, instead of looking at the
    filesystem.
    
    The three implementations are replaced by just one, which uses callbacks
    to determine which files are directories and to enumerate their
    contents. This enables it to be used either with real files on disk or
    off of a packet's metadata.
    plietar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e616d8e View commit details
    Browse the repository at this point in the history