Refactor directory expansion. #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were three separate implementations of directory expansion spread across the codebase, each accepting slightly different inputs. The one used by `orderly_resource` operated over a single vector of paths. The one used by `orderly_shared_resource` operated over a dataframe of `there`/`here` columns. Finally the one used by `orderly_copy_files` used the packet metadata to enumerate files, instead of looking at the filesystem. The three implementations are replaced by just one, which uses callbacks to determine which files are directories and to enumerate their contents. This enables it to be used either with real files on disk or off of a packet's metadata.
richfitz
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three separate implementations of directory expansion spread across the codebase, each accepting slightly different inputs. The one used by
orderly_resourceoperated over a single vector of paths. The one used byorderly_shared_resourceoperated over a dataframe ofthere/herecolumns. Finally the one used byorderly_copy_filesused the packet metadata to enumerate files, instead of looking at the filesystem.The three implementations are replaced by just one, which uses callbacks to determine which files are directories and to enumerate their contents. This enables it to be used either with real files on disk or off of a packet's metadata.