Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: query for nested interface #56

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BarryThePenguin
Copy link

@BarryThePenguin BarryThePenguin commented May 30, 2022

I added a field and query to the tests that reproduces the issue I've been facing

I fixed my original issue by adding a isList argument to resolveInterface(), similar to resolveUnion(). This allows resolveInterface() to resolve a field that is a list with resolveList().

Fixes #55

@jneurock
Copy link
Collaborator

jneurock commented Jun 7, 2022

@BarryThePenguin, thanks for opening this PR! Is the intention to add a failing test or is it to fully fix the issue you reported? Thanks!

@BarryThePenguin
Copy link
Author

It was a failing test originally, just the schema changes alone were enough to reproduce the issue.

I ended up fixing my original issue by using resolveList() in my custom field resolver, so I had a go at including that in resolveInterface() to see if that would fix the tests.

I'll have a go at separating the two commits 👀

@jneurock
Copy link
Collaborator

jneurock commented Jun 7, 2022

Cool. Don't feel you have to separate the commits into separate PRs, if that's what you meant. Feel free to update the PR title and description to match the changes and mention that it fixes your issue # and all should be good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected Iterable, but did not find one for field
2 participants