tests: interface list

miragejs · May 30, 2022 · 8cdd9fe · 8cdd9fe
1 parent 89b24f7
commit 8cdd9fe
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 3 deletions.
diff --git a/__tests__/gql/schema.gql b/__tests__/gql/schema.gql
@@ -29,6 +29,7 @@ type Query {
   testInterface(id: ID, label: String): TestInterface
   testInterfaceNonNull(id: ID, label: String): TestInterface!
   testInterfaceOptional(id: ID!): TestInterface
+  testInterfaceMultiple(id: ID, label: String): [TestInterface]
   testObject(id: ID!): TestObject
   testObjectNonNull(id: ID!): TestObject!
   testObjects(size: String): [TestObject]

diff --git a/__tests__/integration/queries/object-kitchen-sink-test.js b/__tests__/integration/queries/object-kitchen-sink-test.js
@@ -28,6 +28,13 @@ describe("Integration | queries | object", function () {
       server.create("test-union-one", { oneName: "foo" }),
       server.create("test-union-two", { twoName: "bar" }),
     ];
+    const testInterfaces = [
+      server.create("test-impl-one", {
+        description: "description",
+        label: "impl",
+      }),
+      server.create("test-impl-two", { label: "impl" }),
+    ];
 
     seedUnassociatedRecords(server);
 
@@ -41,6 +48,7 @@ describe("Integration | queries | object", function () {
       hasManyNonNullField: testOptions,
       hasManyNestedNonNullField: testOptions,
       interfaceField: testImpl,
+      interfaceNestedNonNullField: testInterfaces,
       interfaceNonNullField: testImpl,
       relayConnectionField: testRelayNodes,
       relayConnectionFilteredField: testRelayNodes,
@@ -66,6 +74,10 @@ describe("Integration | queries | object", function () {
       hasManyNonNullField: [{ id: "1", name: "opt" }],
       hasManyNestedNonNullField: [{ id: "1", name: "opt" }],
       interfaceField: { id: "1", label: "impl" },
+      interfaceNestedNonNullField: [
+        { id: "2", label: "impl", description: "description" },
+        { id: "1", label: "impl" },
+      ],
       interfaceNonNullField: { id: "1", label: "impl" },
       relayConnectionField: {
         edges: [{ cursor: "VGVzdFJlbGF5Tm9kZToy", node: { id: "2" } }],

diff --git a/__tests__/unit/resolvers/mirage-field-resolver-test.js b/__tests__/unit/resolvers/mirage-field-resolver-test.js
@@ -106,6 +106,23 @@ describe("Unit | resolvers | mirage field resolver", function () {
         args,
         context,
         info,
+        false,
+        type
+      );
+    });
+
+    it("can resolve interface list types", function () {
+      const type = typeMap.TestInterface;
+      const info = { returnType: queryFields.testInterfaceMultiple.type };
+
+      mirageGraphQLFieldResolver(obj, args, context, info);
+
+      expect(resolveInterface).toHaveBeenCalledWith(
+        obj,
+        args,
+        context,
+        info,
+        true,
         type
       );
     });

diff --git a/lib/resolvers/interface.js b/lib/resolvers/interface.js
@@ -1,3 +1,4 @@
+import resolveList from "./list";
 import resolveObject from "./object";
 
 function getTypeFromInlineFragment(info) {
@@ -39,15 +40,25 @@ function resolveFromImplementations(obj, args, context, info, type) {
  * @param {Object} args
  * @param {Object} context
  * @param {Object} info
+ * @param {Boolean} isList
  * @param {Object} type An unwrapped type.
  * @see {@link https://graphql.org/learn/execution/#root-fields-resolvers}
  * @see resolveObject
  * @returns {Object} A record from Mirage's database.
  */
-export default function resolveInterface(obj, args, context, info, type) {
+export default function resolveInterface(
+  obj,
+  args,
+  context,
+  info,
+  isList,
+  type
+) {
   const implType = getTypeFromInlineFragment(info);
 
-  return implType
+  return isList
+    ? resolveList(obj, args, context, info, type)
+    : implType
     ? resolveObject(obj, args, context, info, implType)
     : resolveFromImplementations(obj, args, context, info, type);
 }
diff --git a/lib/resolvers/mirage.js b/lib/resolvers/mirage.js
@@ -30,7 +30,7 @@ export default function mirageGraphQLFieldResolver(obj, args, context, info) {
   let { isList, type } = unwrapType(info.returnType);
 
   return isInterfaceType(type)
-    ? resolveInterface(obj, args, context, info, type)
+    ? resolveInterface(obj, args, context, info, isList, type)
     : isUnionType(type)
     ? resolveUnion(obj, args, context, info, isList, type)
     : !isObjectType(type)