Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Share API for sharing entry #1992

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Web Share API for sharing entry #1992

merged 4 commits into from
Aug 1, 2023

Conversation

jeankhawand
Copy link
Contributor

@jeankhawand jeankhawand commented Jul 29, 2023 •
edited
Loading

feature(web-share): redirect already shared entry to Web Share API
Do you follow the guidelines?

@jeankhawand
Copy link
Contributor Author

jeankhawand commented Jul 29, 2023 •
edited
Loading

This will allow mobile users to profit from native share picker while for non supported browser used window.location to redirect them

2023-07-29_23-45-17 (1)

@jeankhawand jeankhawand changed the title Web Share API for already shared entry Web Share API for shared entry Jul 30, 2023
@jeankhawand
Copy link
Contributor Author

jeankhawand commented Jul 30, 2023 •
edited
Loading

This should fix issue sharing already shared entries for standalone PWA. while for createShareEntity which does a redirect we need to work on it in a way to fetch share url and do redirect implicitly in JS
closes #1984 #1254

@jeankhawand
feat(web-share-api): allow newly shared entries to be copied or sent …
798b2a8 
…to other app via Web Share API additionally handle redirect for unsupported browsers in JSx

update(entry dataset attribute): change from entry to status to check whether entry is shared or not
@jeankhawand
Copy link
Contributor Author

I think now it is covering both cases :)

@jeankhawand jeankhawand changed the title Web Share API for shared entry Web Share API when sharing entry Jul 30, 2023
@jeankhawand jeankhawand changed the title Web Share API when sharing entry Web Share API for sharing entry Jul 30, 2023
fguillot
fguillot reviewed Jul 31, 2023
View reviewed changes
ui/static/js/app.js Outdated Show resolved Hide resolved
This was linked to issues Aug 1, 2023
/share Links still require signing in to miniflux #1984
Closed
PWA: Share Button Open In Browser Instead of Within PWA #1254
Closed
@fguillot fguillot merged commit 061f12f into miniflux:main Aug 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fguillot fguillot Awaiting requested review from fguillot

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/share Links still require signing in to miniflux PWA: Share Button Open In Browser Instead of Within PWA
2 participants
@jeankhawand @fguillot