[E-Document Connector] SignUp E-Document Connector #27261
Conversation
|
@aholstrup1 This pull request has replaced #27084 due to using merge instead of rebase policy locally. Thank you for your patience |
geschwint
requested review from
Groenbech96,
WaelAbuSeada and
aholstrup1
as code owners
…x or production. To be populated manually.
Apps/W1/EDocumentsConnector/app/src/SignUp/APIRequests.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentsConnector/app/src/SignUp/APIRequests.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentsConnector/app/src/Permissions/EDocConnectorEdit.PermissionSet.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentsConnector/app/src/Permissions/EDocConnectorObjects.PermissionSet.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentsConnector/app/src/Permissions/EDocConnectorRead.PermissionSet.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentsConnector/app/src/Permissions/EDocConnectorRead.PermissionSet.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentsConnector/app/src/SignUp/APIRequests.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentsConnector/app/src/SignUp/APIRequests.Codeunit.al
Outdated
Show resolved
Hide resolved
|
Comment on last commit. Resolving object name conflict in module. Can't have two objects with the same name in the same module even if they are in different namespaces. Ref: https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-namespaces-overview Error in build: https://github.com/microsoft/ALAppExtensions/actions/runs/10956384133/job/30482980067?pr=27261 |
Yep i was looking at this issue as well yesterday. Can you find me and ping me on the E-Doc Open Source teams channel? |
…ppExtensions into edocumentconnector
|
Latest batch of updates, no changes in logic. Refactoring done to follow structure of incoming Avalara relocation. |
|
Build process fails as required field "Service Participant Id" is missing on the table Customer. Build depends on other pull request to complete. |
Apps/W1/EDocumentsConnector/app/src/SignUp/APIRequests.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentsConnector/app/src/SignUp/APIRequests.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentsConnector/app/src/SignUp/APIRequests.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentConnectors/SignUp/app/src/Connection.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentConnectors/SignUp/app/src/Processing.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentConnectors/SignUp/app/src/Processing.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentConnectors/SignUp/app/src/APIRequests.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentConnectors/SignUp/app/src/Processing.Codeunit.al
Outdated
Show resolved
Hide resolved
| JsonManagement.GetArrayPropertyValueAsStringByName('status', Value); | ||
|
|
||
| if Value in ['Sent'] then begin | ||
| GetReadyStatus.ScheduleEDocumentJob(Codeunit::GetReadyStatus, BlankRecordId, 120000); |
There was a problem hiding this comment.
Couple of things:
- Dont schedule jobs from a function called "HasSomething". It should check a state.
- Question @geschwint What is the flow here? Why cant you rely on the GetResponse job queue job to run?
- Want to understand the logic here.
… more logical name
Here is the link to the API: https://edoc.exflowdev.cloud/swagger/index.html |
E-Documents connector interface implementation between Business Central and SignUp Web API for electronic invoices
Work Item(s)
Fixes #27054
Fixes AB#541805