[E-Document Connector] SignUp E-Document Connector #27084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes [AB#420000](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/420000) --------- Co-authored-by: Alexander Holstrup <[email protected]>
This pull request does not have a related issue as it's part of delivery for development agreed directly with @AndreiPanko Added a setting to the shopify shop to use original return location (From shopify) or a default return location set in the Shopify shop when creating Credit Memos for Refunds. Modified the return and refund creation to pull original location from shopify refund or return orders. When an item on a single return order in shopify is restocked to multiple locations, we cannot determine a single location to put on a return line. If there is any reason that Original location couldn't be determined then the Default Return Location will be used during the creation of a Credit Memo. Fixes microsoft#26819 Fixes [AB#540965](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/540965) --------- Co-authored-by: Tine Staric <[email protected]>
This pull request does not have a related issue as it's part of delivery for development agreed directly with @AndreiPanko Quick summary: The Shopify Shipping Method Mapping page/table was extended to include a new Shipping Charges Type field, allowing users to select from GL, Item, or Item Charge. Depending on this selection, the Shipping Charges No. field opens the related table (item, GL, or item charges), and when an order is created, the shipping charge line reflects the new type and number. For Item Charges, a default allocation process is run for all item lines. The settings in the Shopify Shipping Method Mapping now take priority over those in the Shopify Shop - GL Account settings. Additionally, if the Shipping Agent Code and Shipping Agent Service fields are populated, they are automatically populated in the sales order as well. Fixes microsoft#26819 [AB#449477](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/449477) --------- Co-authored-by: aidasberesinevicius <[email protected]> Co-authored-by: Tine Staric <[email protected]>
This pull request does not have a related issue as it's part of delivery for development agreed directly with @AndreiPanko Added an action to Variants subpage to add BC Items as additional Variants to an existing Shopify Product. If the parent product only had a default variant before the addition, it is deleted from both Shopify and BC. The variants are added under the existing the Product Option (ex. Color, Material, or Title, if product only had the default variant) Items cannot be added if the shop has "UOM as Variant" enabled, or if the parent product has more than one option defined. Fixes microsoft#26819 Fixes [AB#468218](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/468218) --------- Co-authored-by: Tine Staric <[email protected]> Co-authored-by: Jesper Schulz-Wedde <[email protected]> Co-authored-by: Onat Buyukakkus <[email protected]>
) Added US to Yavrio Open Banking Fixes [AB#543398](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/543398)
Fixes [AB#420000](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/420000) --------- Co-authored-by: Jesper Schulz-Wedde <[email protected]>
#### Summary <!-- Provide a general summary of your changes --> Added a new field "Request URL" to table 6127 "E-Document Integration Log" with a maximum string length of 2048 to allow for longer URLs when using the "E-Document Integration" interface. The new filed replaces the existing field URL. I marked the existing field as obsolete and updated three (all) references from the old URL field to the new "Request URL" field. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes microsoft#26672 Fixes [AB#540448](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/540448) --------- Co-authored-by: Patrick Lüthi <[email protected]>
|
Not much will change now. Essentially done. I'll have this as Draft at the moment as I might do really minor adjustments in certain cases. |
geschwint
requested review from
Groenbech96,
WaelAbuSeada and
aholstrup1
as code owners
|
Be advised that this pull request depends on the completion of pull request #27051 as I am using new fields from table Customer |
|
@aholstrup1 I wonder if something went wrong. I noticed your force-push of changes into main, thus I pulled the changes into my fork and accepted all incoming changes. Then I merged into my branch and pushed to get in sync. Still indication of 107 files changed and we only changed/added files below EDocumentsConnector folder. Asking for advice |
|
Hi @geschwint, I had the same issue as you. I synced my fork, cherry-picked my commits, and then created a new PR (to get rid of the unwanted commits in the PR). A cherry-pick or rebase is necessary, i guess. If you merge, you'll bring the altered commits back (since the forced git push wasn’t executed on your side). There might be a better way, but this approach worked for me in the end. |
|
Hi @plakna Sounds reasonable. I will do that. CC @aholstrup1 |
|
@aholstrup1 This pull request has been replaced by #27261 Due to using merge and not rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
E-Documents connector interface implementation between Business Central and SignUp Web API for electronic invoices
Work Item(s)
Fixes #27054
Fixes AB#541805