Upgrade Earlinet reader and implement vertical profiles #855
Conversation
lewisblake
added
obs-update
|
Some stations have netcdf with multiple observations (timesteps). We currently kick them out. Could think of a more elegant solution, but that would need some input from others |
pyaerocom/colocation_3d.py
Outdated
| if regrid_res_deg is not None: | ||
| data = _regrid_gridded(data, regrid_scheme, regrid_res_deg) |
There was a problem hiding this comment.
if these lines are nor covered by test, maybe the if clause should be marked with # pragma: no cover
pyaerocom/colocation_3d.py
Outdated
| if use_climatology_ref: | ||
| col_freq = "monthly" | ||
| obs_start = const.CLIM_START | ||
| obs_stop = const.CLIM_STOP |
There was a problem hiding this comment.
seem my prebious comment about not covered lines
| TEST_FILE = [ | ||
| ROOT / "earlinet_example_for_ci.pkl", | ||
| ] |
There was a problem hiding this comment.
I'm not convinced that pickeø files will work across different versions of Python and numpy/netCDF4
There was a problem hiding this comment.
I agree this is a concern. Either we find a more robust way of storing the UngriddedData object (not obvious to me now, would require some research), or I write a fixture to create this UngriddedData object on the fly. I'm happy to open a PR to patch this after the fact if you are okay merging for now
Need to upgrade the EARLINET reader to the new format, and move VerticalProfiles through the rest of the pyaerocom pipeline to Aeroval.