Force to rerun cmake before building from the custom build target.

[rdebroiz]

This is needed thanks to our awesome way to list files to add to a project (no comment please).

It also fixes a kind of bug, that caused certain project build twice. the problem was that we rely on the ${binary_dir } variable to know from where run the build command of each project but it was empty for DCMTK and the command was running by default from {CMAKE_BINARY_DIR}. in other words instead of build DCMTK we were just building one more time the whole super project...

I also take the oportunity to integrate the PR #33.

The PR#43 is also integrated, except the DDCMTK_OVERWRITE_WIN32_COMPILER_FLAGS:BOOL=OFF. (i can't tell wich is the best i just know that i had some trouble in other projects with this variable to ON)

[papadop]

Sorry cannot resist to comment ;-):

This is needed thanks to our awesome way to list files to add to a project (no comment please).
-1 but you already all know I would vote like that ;-)

[rdebroiz]

@papadop I understand ;)

[rdebroiz]

papadop commented on 3e3c54c 10 days ago

Either boost is required for all arch 1) or not 2).
If 1) then the find_package is for all arch.
if 2) the Boost stuff in cmake_args should br conditional (no point of defining variable with incorrect values).

well, if you run the superproject on windows it fail at the medirnia step and ask for the Boost_INCLUDE_DIR, that's why I add this.

[rdebroiz]

if 2) the Boost stuff in cmake_args should br conditional (no point of defining variable with incorrect values).

Done.

[gpasquie]

Good for me

[ocommowi]

I'm having quite a hard time with Boost on jenkins release jobs. It would seem that this branch could solve it. Do we merge it or is there anything against it ?

[ocommowi]

Alright I found a workaround, so no need to merge this one if we don't want to

[fvichot]

So, we just had the Jenkins Unix slaves fail because of your "awesome way to list files to add to a project" 👍

When a file is removed, CMakeLists aren't directly modified any more, so CMake doesn't know to re-generate the Makefiles, and so we get errors about missing files to generate targets. I fixed it in Jenkins by adding: cmake --build medinria-superbuild/bld/medInria/build --config Release --target rebuild_cache in the build steps, then remembered this PR existed.

I'm in favour of adding the force-configure-then-build for the build target that this PR introduces, but not so sure about the rest. Do we still need the Boost stuff ? @rdebroiz ?

[rdebroiz]

Yes. it's used in medVtkInria for the legendre function in one file related to the SH.

[fvichot]

OK, so I'm in favour or merging this. Could someone on windows make sure this doesn't break anything ? @Hakim-F or @LoicCadour

[LoicCadour]

I'll watch this (or make @Hakim-F watch this) when I have time.