This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
USE_GITHUB_SSH and PRIVATE_PLUGINS_DIRS are not mark as advanced anymore... #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me, is everyone ok with these variables becoming public ? |
|
Fine with me, though I don't see the point :) You guys know you can search for a variable name in ccmake with '/' right ? |
|
In this case, the number of non-advanced variables is quite small and I think that making these two variables un-advanced can simplify developers life (search is easy when you know what to find). More generally, I'm not opposed to make a few more non-advanced (MEDINRIA_TEST_DATA_ROOT, maybe some CPACK or FLAGS ones though this is more controversial). On the other hand, we could make QT_QMAKE_EXECUTABLE advanced ;-) |
|
Closing...Integrated in #45 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A really small PR, because it is painful to scroll to the bottom of the list of advanced varibales looking for those two ones.